feat: optional serialization support for core types #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rklaehn
commented
Mar 27, 2025
•
rklaehn
commented
- serialisation support (optional, via serde features)
- eliminate macro that was used just once
- more generic callbacks in experimental mixed io package
todo: make this optional
It is used in exactly one place!
There was a problem hiding this comment.
Pull Request Overview
This PR introduces serialization support via serde, removes an underused macro, and refactors some callbacks in the experimental mixed io package to be more generic.
- Added serde traits to several types and updated documentation for the hash_subtree workaround.
- Refactored integer rounding operations to use div_ceil and changed the sender API in the mixed io module.
- Updated Cargo.toml to enable serde features and removed the macros module that was used only once.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Added serde imports, made hash_subtree public with updated docs, and updated rounding with div_ceil. |
| src/io/mod.rs | Introduced serde serialization/deserialization for Parent and BaoContentItem. |
| src/io/mixed.rs | Updated the sender trait to be generic and adjusted error propagation. |
| src/tree.rs | Replaced the macros-based newtype with a manual implementation using serde. |
| src/io/error.rs | Added serde support to EncodeError with a custom serializer for io::Error. |
| Cargo.toml | Enabled serde support for bytes and added serde as an optional dependency. |
| src/macros.rs | Removed the unused macros module. |
rklaehn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.